fix: preserve aliased native constructor proofs - #8278
Conversation
|
Warning Review limit reached
Next review available in: 31 minutes Limit details: You’ve used all 8 included reviews currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Merging. This clears #8222, which #8273 named as one of the remaining The design is fail-closed in the direction that matters. A wrong proof here is a miscompile — native method dispatch applied to a class that isn't native — so Verified here:
|
Summary
Testing
cargo test -p perry-codegen --lib imported_native_constructor_proof --release -- --nocapturecargo test -p perry --test aliased_native_class_import --release aliased_net_socket_keeps_native_methods -- --exact --nocapturecargo test -p perry --test aliased_native_class_import --release aliased_matches_unaliased_for_native_class -- --exact --nocapturecargo fmt -p perry-codegen -- --checkpython scripts/check_test_registration.pyFixes #8222